Skip to content

Add pr options to msync execute - #384

Merged
bastelfreak merged 1 commit into
voxpupuli:masterfrom
Joris29:msync_exec_git
Nov 3, 2026
Merged

bastelfreak merged 1 commit into
voxpupuli:masterfrom
Joris29:msync_exec_git

Conversation

@Joris29

@Joris29 Joris29 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@Joris29

Joris29 commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Working example can be found at: Joris29/puppet-rundeck#1

@marcusdots marcusdots left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is awesome. I recommend to fix rubocop and continue with this idea.

Comment thread lib/modulesync.rb Resolved
@Joris29
Joris29 force-pushed the msync_exec_git branch 2 times, most recently from 3b79f84 to 882be9d Compare October 27, 2026 13:18
@Joris29
Joris29 marked this pull request as ready for review October 27, 2026 13:33

@marcusdots marcusdots left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the scope with a solution of your liking and I will approve this PR?

Comment thread lib/modulesync.rb Resolved
Comment thread lib/modulesync.rb Resolved
@marcusdots

Copy link
Copy Markdown

I would like to add one request:
Can you please git rebase --signoff, so Vox Pupulis Github demand

Commits must have verified signatures.

gets satisfied?

@Joris29
Joris29 force-pushed the msync_exec_git branch 4 times, most recently from d7defe9 to 96e9c7d Compare November 3, 2026 13:27
Comment thread lib/modulesync.rb Resolved
Comment thread lib/modulesync.rb Resolved
@Joris29
Joris29 force-pushed the msync_exec_git branch 2 times, most recently from ec4d8df to d360368 Compare November 3, 2026 15:42
@bastelfreak

Copy link
Copy Markdown
Member

@Joris29 your commits are still not signed with a gpg or ssh key. Can you please do that?

@Joris29
Joris29 force-pushed the msync_exec_git branch 2 times, most recently from ca7c933 to 0aae25e Compare November 3, 2026 17:47
Signed-off-by: Joris29 <joris.vanacoleyen@bryxx.eu>
@Joris29

Joris29 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Got it signed.

@bastelfreak
bastelfreak merged commit 19db3ae into voxpupuli:master Nov 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants